Skip to content

Strengthen feedback escalation coverage#61

Merged
SilverSupplier merged 2 commits into
sw1029:mainfrom
SilverSupplier:codex/feedback-escalation-coverage
May 25, 2026
Merged

Strengthen feedback escalation coverage#61
SilverSupplier merged 2 commits into
sw1029:mainfrom
SilverSupplier:codex/feedback-escalation-coverage

Conversation

@SilverSupplier

@SilverSupplier SilverSupplier commented May 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Strengthen feedback escalation tests for repeated failures and assisted success states.
  • Verify stable metadata such as assist level, hintShown, assisted, and failure count without pinning full copy strings.
  • Replace brittle CSV substring checks with checks against the final assist-related CSV fields.
  • Add a small reason-hint fallback so empty recognition hints still produce a family-specific action hint.

Related Issues

Merge Order

  • Ready to merge directly into main: GitHub reports MERGEABLE / CLEAN after the latest branch refresh.
  • No prerequisite PR remains open for this branch. The earlier base-family feedback prerequisite has already landed in main.
  • Suggested remaining queue: Improve overlay failure hints #59 -> this PR -> Strengthen final floor guidance and ending #63. Local merge-tree simulation confirmed that queue has no content conflicts as of 2026-05-26.

Verification

  • Latest GitHub build, test, validate-docs, and codeql checks passed after refreshing the branch.
  • Local merge-tree simulation against the remaining open PRs passed without content conflicts.
  • Previous Unity EditMode coverage was added for escalation state, assisted-success metadata, fallback hints, and CSV assist fields.
  • npm test; Not run locally, Unity-only change.
  • npm run build; Not run locally, Unity-only change.

Notes

  • Scope: feedback escalation regression coverage, assist metadata assertions, CSV assist-field assertions, and defensive reason-hint fallback.
  • Risk notes: this mostly strengthens tests, but the fallback path changes user-facing hint behavior when a recognition result has no explicit hint.

Review Checklist

  • This PR changes user-facing UI or behavior.
  • This PR changes recognizer behavior.
  • This PR changes docs, task state, or project process.
  • This PR changes ML artifacts, datasets, generated outputs, or capture/export behavior.
  • This PR changes logging, survey fields, privacy, or research data handling.
  • This PR needs screenshots or a short playtest note.

Screenshots / Playtest Notes

No screenshot needed; EditMode coverage verifies escalation state, assisted-success metadata, fallback hints, and CSV assist fields.

…tion-coverage

# Conflicts:
#	unity/MagicExamHall/Assets/Tests/EditMode/GestureRecognizerTests.cs
@SilverSupplier SilverSupplier merged commit 1b21ad2 into sw1029:main May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Child #14] feedback escalation 테스트 보강

1 participant